Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): describe new drop_tip() behavior introduced in PAPI 2.18 #15078

Merged
merged 2 commits into from
May 6, 2024

Conversation

ecormany
Copy link
Contributor

@ecormany ecormany commented May 2, 2024

Overview

Describe the new apiLevel-gated behavior for drop_tip() in Python API 2.18.

Addresses RTC-448

Test Plan

Sandbox API ref entry

Changelog

Move ¶ about change in 2.15 down, and add another ¶ about 2.18.

Review requests

This is how it works, right?

Risk assessment

None, docstring only.

@ecormany ecormany added docs papi-v2 Python API V2 labels May 2, 2024
@ecormany ecormany requested a review from jbleon95 May 2, 2024 20:18
@ecormany ecormany requested a review from a team as a code owner May 2, 2024 20:18
@ecormany ecormany force-pushed the docs_release-2.18 branch from cdecc11 to a55d47a Compare May 2, 2024 20:53
@ecormany ecormany force-pushed the docstring-drop-tip-alternating-2.18 branch from 87ad535 to 3f37a9e Compare May 2, 2024 20:55
Copy link
Contributor

@jbleon95 jbleon95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and describes the behavior accurately. Small comment on specificity but otherwise ✅

@ecormany ecormany merged commit bde78c9 into docs_release-2.18 May 6, 2024
20 checks passed
@ecormany ecormany deleted the docstring-drop-tip-alternating-2.18 branch October 16, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs papi-v2 Python API V2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants